Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor avalon.tools to avoid cross-referencing imports between tools #440

Merged
merged 22 commits into from
Sep 10, 2019
Merged

Refactor avalon.tools to avoid cross-referencing imports between tools #440

merged 22 commits into from
Sep 10, 2019

Commits on Sep 4, 2019

  1. Refactor tools cross-referencing each other, plus cleanup: 

    - Remove AssetView class which solely set 3 properties on the TreeView
- Refactor `Node` to `Item` as it is for QAbstractItemModels
- Refactor some variables to `snake_case` as opposed to `lowerCamelCase`
- Add some todo notes (notes to self for cleanup)
    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    72ba84f View commit details
    Browse the repository at this point in the history

  2. Refactor absolute import to relative import

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    e31d9d9 View commit details
    Browse the repository at this point in the history

  3. Fix import consistency, order by most global to closest relative

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    d07dcf6 View commit details
    Browse the repository at this point in the history

  4. Refactor node to item in variables for consistency/clarity

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    e2b59e7 View commit details
    Browse the repository at this point in the history

  5. Refactor family and group config cache from loader.lib to tools.lib 

    - Plus clarify that the group/family config data is a cache.
    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    c350d18 View commit details
    Browse the repository at this point in the history

  6. Refactor model COLUMNS to columns

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    93ed86f View commit details
    Browse the repository at this point in the history

  7. Fix refactored imports

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    5ea6fb7 View commit details
    Browse the repository at this point in the history

  8. Fix refactored Qt

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    df4ec95 View commit details
    Browse the repository at this point in the history

  9. Fix missing QtGui import

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    90e159e View commit details
    Browse the repository at this point in the history

  10. Fix some outdated/wrong docstrings

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    8bf7bc8 View commit details
    Browse the repository at this point in the history

  11. Use list literal

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3904439 View commit details
    Browse the repository at this point in the history

  12. Move utility function to top (ease debugging import error stack trace)

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    dc1a3fc View commit details
    Browse the repository at this point in the history

  13. Move RecursiveSortFilterProxyModel to tools.models + fix imports

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    27449a5 View commit details
    Browse the repository at this point in the history

  14. Comment example code again as it requires database/qt app to pass tests

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    4c6343a View commit details
    Browse the repository at this point in the history

  15. Remove unused model

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    bc3df32 View commit details
    Browse the repository at this point in the history

  16. Fix missed refactoring of model.COLUMNS to model.columns

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    db6f6e6 View commit details
    Browse the repository at this point in the history

  17. Fix refactor of NodeRole to ItemRole

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    a475623 View commit details
    Browse the repository at this point in the history

  18. Remove "import as" for qtawesome imports

    @BigRoy
    BigRoy committed Sep 4, 2019
    Configuration menu
    Copy the full SHA
    9bc098e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Unify quote style from single quotes to double quotes (only in tools)

    @BigRoy
    BigRoy committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    ae70d90 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Refactor model columns to Columns to separate from variables and methods

    @BigRoy
    BigRoy committed Sep 6, 2019
    Configuration menu
    Copy the full SHA
    8f798ca View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Cleanup multiple lib imports + reduce importing of specific functions

    @BigRoy
    BigRoy committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    5de72f3 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. Bump version to 5.4.0

    @BigRoy
    BigRoy committed Sep 10, 2019
    7 Configuration menu
    Copy the full SHA
    3fa9636 View commit details
    Browse the repository at this point in the history