feat(workers): Optional Admin and Console Server Workers #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make Admin and Console workers optional via env variable
eschutho
approved these changes
Sep 3, 2024
|
@Antonio-RiveroMartnez have you been able to validate that running things works correctly? Just curious if there are any assumptions in the other required pieces that these services are running. |
It works correctly for our use case that is only having the API up and served so it can be consumed by the SDK and CLI commands for both SingleMode and ClusterMode. Those other two server workers (Admin and Console) are not needed hence the env variable to opt out. This also allowed us to use less resources. Here you can see how the initialization completes without Admin nor Console: |
jwatzman
added a commit
to jwatzman/cord
that referenced
this pull request
Oct 12, 2024
The optional workers in getcord#24 doesn't quite work right: because env variables are always strings, `generate-dotenv.cjs` will set these two new env vars to the string `'false'` -- which is truthy. So the console and admin workers will always be deactivated unless we set the value to the string `''` or similar, which is confusing for these boolean-sounding settings. Instead, we can just check if the port number is set, and skip if not, which is nice that we don't need a new env var -- you can just set the port number to the empty string to deactivate. This does have a similar issue, in that if you set the port to `0'`, it will still try to activate the optional worker -- but `parseListenPort` will immediately yell that `0` is an invalid port so at least you know immediately.
jwatzman
added a commit
to jwatzman/cord
that referenced
this pull request
Oct 12, 2024
The optional workers in getcord#24 doesn't quite work right: because env variables are always strings, `generate-dotenv.cjs` will set these two new env vars to the string `'false'` -- which is truthy. So the console and admin workers will always be deactivated unless we set the value to the string `''` or similar, which is confusing for these boolean-sounding settings. Instead, we can just check if the port number is set, and skip if not, which is nice that we don't need a new env var -- you can just set the port number to the empty string to deactivate. This does have a similar issue, in that if you set the port to `0'`, it will still try to activate the optional worker -- but `parseListenPort` will immediately yell that `0` is an invalid port so at least you know immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to facilitate the work for #23 we are adding two more env variables to the config so we can opt in/out from the Admin and Console server workers due to their optional nature. By default you would be running all workers as currently does the app.
Ideally we could control which server workers to run when serving your self hosted solution via a Feature Flag, but currently the Feature Flags are managed by LaunchDarkly which would be an optional service after we address #2.