Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail on requesting reviewers #115

Conversation

joneshf
Copy link
Contributor

@joneshf joneshf commented Jul 16, 2022

It's not always possible to request reviewers, so we don't always fail.

Unless you have write access to a repo, you cannot request reviewers for
a PR. Since there are workflows where not everyone has write access, and
we don't want to fail unnecessarily, we don't make it a requirement that
requesting reviewers has to succeed.

Test Plan:

  1. First, ensure you don't have write access to a repo.
  2. Create a commit.
  3. Run spr diff
  4. The PR should be opened and the command should only warn when it
    cannot request reviewers.

Created using spr 1.3.4-beta.1
@joneshf
Copy link
Contributor Author

joneshf commented Jul 16, 2022

Sorry, opened too soon. Lemme try again.

@joneshf joneshf closed this Jul 16, 2022
@joneshf joneshf deleted the spr/joneshf/dont-fail-on-requesting-reviewers branch July 16, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant