Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add postgres columns validations and connector test #1035

Merged

Conversation

hoangnh93
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4269576260

  • 148 of 389 (38.05%) changed or added relevant lines in 2 files are covered.
  • 27 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.08%) to 71.976%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-ingestion/src/connectors/postgres/replication_slot_helper.rs 146 153 95.42%
dozer-ingestion/src/connectors/postgres/connection/validator.rs 2 236 0.85%
Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/typed/tests/service.rs 2 97.79%
dozer-ingestion/src/errors.rs 11 2.78%
dozer-ingestion/src/connectors/postgres/connection/validator.rs 14 9.15%
Totals Coverage Status
Change from base Build 4268765635: 0.08%
Covered Lines: 27546
Relevant Lines: 38271

💛 - Coveralls

@hoangnh93 hoangnh93 force-pushed the fix/add-unit-test-for-postgres-connector branch from ca3291c to edf146f Compare March 3, 2023 02:26
@hoangnh93 hoangnh93 requested a review from karolisg March 3, 2023 16:04
@hoangnh93 hoangnh93 removed the wip label Mar 3, 2023
@karolisg karolisg merged commit eadc6fd into getdozer:main Mar 3, 2023
@hoangnh93 hoangnh93 deleted the fix/add-unit-test-for-postgres-connector branch March 4, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants