Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Window processor #1175

Merged
merged 6 commits into from
Mar 9, 2023

Conversation

mediuminvader
Copy link
Contributor

Implementing WINDOW function as a processor of the DAG

see #893 for details

@mediuminvader mediuminvader self-assigned this Mar 8, 2023
@coveralls
Copy link

coveralls commented Mar 8, 2023

Pull Request Test Coverage Report for Build 4364009619

  • 362 of 1122 (32.26%) changed or added relevant lines in 10 files are covered.
  • 306 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-1.5%) to 74.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dozer-sql/src/pipeline/errors.rs 0 1 0.0%
dozer-sql/src/pipeline/window/operator.rs 89 92 96.74%
dozer-sql/src/pipeline/product/tests/pipeline_test.rs 0 4 0.0%
dozer-sql/src/pipeline/window/processor.rs 0 43 0.0%
dozer-sql/src/pipeline/window/factory.rs 0 57 0.0%
dozer-sql/src/pipeline/builder.rs 89 156 57.05%
dozer-sql/src/pipeline/window/builder.rs 23 226 10.18%
dozer-sql/src/pipeline/window/tests/pipeline_test.rs 0 382 0.0%
Files with Coverage Reduction New Missed Lines %
dozer-api/src/grpc/shared_impl/mod.rs 1 85.71%
dozer-sql/src/pipeline/aggregation/processor.rs 1 97.84%
dozer-api/src/grpc/typed/tests/service.rs 2 97.74%
dozer-storage/src/lmdb_multimap.rs 15 86.61%
dozer-sql/src/pipeline/builder.rs 28 72.42%
dozer-core/src/dag_metadata.rs 45 85.0%
dozer-core/src/dag_impl.rs 69 71.95%
dozer-types/src/types/field.rs 145 65.14%
Totals Coverage Status
Change from base Build 4362929406: -1.5%
Covered Lines: 27704
Relevant Lines: 37182

💛 - Coveralls

@mediuminvader mediuminvader added enhancement New feature or request sql labels Mar 8, 2023
@mediuminvader mediuminvader marked this pull request as ready for review March 8, 2023 11:52
Copy link
Contributor

@snork-alt snork-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we return the schema in the factory do we add the window_start and window-end to the pk ?

@mediuminvader
Copy link
Contributor Author

mediuminvader commented Mar 9, 2023

When we return the schema in the factory do we add the window_start and window-end to the pk ?

@snork-alt

output_schema
.primary_index
.push(output_schema.fields.len() - 1);

just window_start

@mediuminvader mediuminvader merged commit f955e47 into getdozer:main Mar 9, 2023
@mediuminvader mediuminvader deleted the feat-WINDOW-processor branch March 9, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants