-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write dozer.lock #1945
Write dozer.lock #1945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this implementation, I think we can get rid of BuildPath
.
It was designed to contain all information of a specific dozer execution, so user can restart dozer and continue from checkpoint.
Now that the contract file is moved out of it, there's no way to use data left in there anymore, so it makes more sense to just remove BuildPath
and put everything that was previously in BuildPath
to the HomeDir
.
If the contract is consistent with the endpoints, we can still re-use the build, the same way as when the contract was written to the build dir, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
I didn't make myself clear. Before this PR, it's possible to implement such a command:
where we compare the "current" contract with the contract stored in build Now that contract does not exist in the build directory anymore, such command is not possible. And this beats the purpose of the existence of build directories. That's why I said we can get rid of |
Ah, as there is only ever one live build, the home dir in practice becomes the build directory. Luckily the contents of the home dir are an implementation detail, so I will defer this to after versioning |
Currently, this always writes the lock file to the current working directory.
Ideally we would follow the
dozer-config.yaml
around, but that is currentlyimpractical because of the implementation of the
-c
flag, combining*.sql
anddozer-config.*
.