Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow opening browser context without url #1235

Closed
NivedhaSenthil opened this issue May 6, 2020 · 1 comment
Closed

Allow opening browser context without url #1235

NivedhaSenthil opened this issue May 6, 2020 · 1 comment
Assignees
@NivedhaSenthil
Labels
feature

Comments

@NivedhaSenthil
Copy link
Member

NivedhaSenthil commented May 6, 2020 •
edited
Loading

Expected behavior

openIncognitoWindow({name:'admin'}) to open a new incognito window with blank page.

Actual behavior

Expects an url to be passed Error: Url needs to be provided to openIncognitoWindow

Steps to reproduce

  1. openBrowser()
    2.openIncognitoWindow({name:'admin'})

Versions

taiko 1.0.9
node v14.1.0
@NivedhaSenthil NivedhaSenthil mentioned this issue May 6, 2020
Closed
8 tasks
@NivedhaSenthil NivedhaSenthil self-assigned this May 8, 2020
NivedhaSenthil added a commit that referenced this issue May 8, 2020
@NivedhaSenthil
#1235 make url optional for openIncognitoWindow
a07aa62 
Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
NivedhaSenthil added a commit that referenced this issue May 12, 2020
@NivedhaSenthil
#1235 make url optional for openIncognitoWindow (#1240)
4707e4a 
* #1235 make url optional for openIncognitoWindow

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>

* update version to 1.0.10

Signed-off-by: NivedhaSenthil <nivedhasenthil@gmail.com>
@NivedhaSenthil
Copy link
Member Author

Fixed as part of #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NivedhaSenthil NivedhaSenthil

Labels
feature
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NivedhaSenthil