Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeTab user acknowledge message should be correct #849

Closed
Debashis9012 opened this issue Sep 30, 2019 · 1 comment
Closed

closeTab user acknowledge message should be correct #849

Debashis9012 opened this issue Sep 30, 2019 · 1 comment
Assignees
Labels

Comments

@Debashis9012
Copy link
Contributor

Debashis9012 commented Sep 30, 2019

Expected behavior

When a user using closeTab api with a page title then taiko should intelligently figures out the tab as per the title and close it. If taiko did not get the valid page title to close then it should tell the user that "provided page title does not exists" or "kindly enter the valid page title "

Actual behavior

For an example "Google.com" correct page tile is "Google".
If we perform clostTab with the wrong title then it shows the below user message:

> closeTab("google")
 ✔ Closed all tabs with URL google

Note: There is no page title in the current active browser with the title 'google'

In taiko document section there is no example of closeTab with the page title.

Steps to reproduce

> openBrowser()
> goto("Google.com")
> title()
 value: 'Google'
> closeTab("google")
 ✔ Closed all tabs with URL google

Versions

Tested version: Version: 1.0.2 (Chromium: 76.0.3803.0) 22a7d58c629864e04042d4661046d0c3e8e802cd
@Debashis9012
Copy link
Contributor Author

Tested the above issue,
currently If taiko did not get the valid page title to closeTab then its throwing ✘ Error: No target with given URL/Title found., run .trace for more info. which is a valid user message to rectify the url/page title.
and closeTab with page title example has been added to taiko document section.

Hence this issue has been verified and found fixed.

Tested version: Version: 1.0.2 (Chromium: 76.0.3803.0) 9b0b3fc46c78e2596c9dad34e9a0ce69abf3be30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants