Add new devices for mobile emulation #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hdzogovic <h.dzogovic@icloud.com>
|
@zabil Hello, I don't know why the unit tests are not passing. On my local machine, all the tests pass. And I don't see a reason why the tests should fail based on my changes. Can you help me out somehow? |
|
It looks like the github action windows vm's has performance issues at the moment. Will need to wait till that resolves. Will re-trigger tomorrow and see how it goes. |
Thanks a lot! |
saikrishna321
pushed a commit
that referenced
this pull request
Mar 17, 2022
Signed-off-by: hdzogovic <h.dzogovic@icloud.com> Co-authored-by: hdzogovic <h.dzogovic@icloud.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
saikrishna321
pushed a commit
that referenced
this pull request
Mar 19, 2022
Signed-off-by: hdzogovic <h.dzogovic@icloud.com> Co-authored-by: hdzogovic <h.dzogovic@icloud.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
saikrishna321
pushed a commit
that referenced
this pull request
Mar 19, 2022
Signed-off-by: hdzogovic <h.dzogovic@icloud.com> Co-authored-by: hdzogovic <h.dzogovic@icloud.com> Signed-off-by: saikrishna321 <saikrishna321@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haris Dzogovic haris@dzogovic.de