Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS packages and Chromium #2676

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

marques-work
Copy link
Contributor

@marques-work marques-work commented Jan 12, 2023

Bumping to 1.3.8 + updating packages.

cc: @zabil

Signed-off-by: Marques Lee <marques.lee@thoughtworks.com>
Signed-off-by: Marques Lee <marques.lee@thoughtworks.com>
@gaugebot
Copy link

gaugebot bot commented Jan 12, 2023

@marques-work Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@zabil zabil merged commit ff34a64 into getgauge:master Jan 12, 2023
@marques-work
Copy link
Contributor Author

marques-work commented Jan 13, 2023 via email

@zabil
Copy link
Member

zabil commented Jan 13, 2023

From netlify, issue with the node function that netlify uses to run webhooks as fetch comes with node 18

Jan 13, 07:50:28 AM: 60bfaaef 
ERROR  ReferenceError: fetch is not definedJan 13, 07:50:28 AM: 60bfaaef 
ERROR      at prClosed (/var/task/netlify/functions/webhook.js:46:22)Jan 13, 07:50:28 AM: 60bfaaef 
ERROR      at /var/task/node_modules/@octokit/webhooks/dist-node/index.js:177:14Jan 13, 07:50:28 AM: 60bfaaef 
ERROR      at async Promise.all (index 0)Jan 13, 07:50:28 AM: 60bfaaef 
ERROR      at async Runtime.handler (/var/task/netlify/functions/webhook.js:85:5)

@marques-work
Copy link
Contributor Author

marques-work commented Jan 13, 2023 via email

@zabil
Copy link
Member

zabil commented Jan 13, 2023

Yes, looks like I need to set an environment variable to use node 18 instead of 16, according to

https://docs.netlify.com/functions/optional-configuration/?fn-language=ts#node-js-version-for-runtime

@zabil
Copy link
Member

zabil commented Jan 13, 2023

@marques-work that fixed it! The new release is now out. Thanks for being patient and following up.

@marques-work
Copy link
Contributor Author

marques-work commented Jan 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants