Add informative documentation for alert/prompt/confirm/beforeunload #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikrishna321
approved these changes
Dec 19, 2019
negiDharmendra
suggested changes
Dec 23, 2019
lib/taiko.js
Outdated
| * // Note: Taiko's `alert` listener has to be setup before the alert | ||
| * // displays on the page. For example, if clicking on a button | ||
| * // shows the alert, the Taiko script is | ||
| * await alert('Message on alert' => accept()) |
There was a problem hiding this comment.
It should be alert('Message on alert', async () => accept())
lib/taiko.js
Outdated
| * // Note: Taiko's `prompt` listener has to be setup before the prompt | ||
| * // displays on the page. For example, if clicking on a button | ||
| * // shows the prompt, the Taiko script is | ||
| * await prompt('Message on prompt' => accept('Something')) |
There was a problem hiding this comment.
It should be prompt('Message on prompt', () => accept('Something'))
lib/taiko.js
Outdated
| * // Note: Taiko's `confirm` listener has to be setup before the confirm | ||
| * // popup displays on the page. For example, if clicking on a button | ||
| * // shows the confirm popup, the Taiko script is | ||
| * await confirm('Message on prompt' => accept()) |
There was a problem hiding this comment.
It should be confirm('Message on confirm', () => accept())
negiDharmendra
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make things clear with an example as a lot of questions about this keep coming up.