Cannot change image format in Grav 1.7

[fdruide]

I found a regression in Grav 1.7.3 from Grav 1.6.31 while doing HTML diff of our website. We have a template where we use the image format method to replace several PNG to JPG. However, it remains in PNG in Grav 1.7.3. I hope this is not a repost.

Here is the minimal steps to reproduce the problem :

1. Get a clean install of Grav core 1.7.3
2. Modify user/themes/quark/templates/default.html.twig with the following content:

{% extends 'partials/base.html.twig' %}

{% block content %}
    {% set img = page.media.images|first %}
    <img src="{{ img.format('jpg').url() }}" />
    {{ page.content|raw }}
{% endblock %}

3. Add the included PNG image inside the following folder : user/pages/01.home/
   

4. Load the main page.

Actual result in Grav 1.7.3, the image is still a PNG (the transparency is still there):

Expected result as in Grav 1.6.31, the image becomes JPG :

The problem is in ImageMediaTrait::saveImage. The format is overridden with the following code :

            $extension = strtolower($this->get('extension'));
            $this->format($extension);

I think the fix would be to verify the format is actually set to guess before getting the file’s extension :

        if ($this->format == 'guess') {
            $extension = strtolower($this->get('extension'));
            $this->format($extension);
        }

In that case, if we set the format prior hand, our requested format would not be overridden.

Thank you for your time,
François

[NicoHood]

This can be closed now