Add cookie domain configuration under system.session #2040
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new config under "system.session" called "domain".
The current implementation is
This is problematic under docker-compose because the hostname is the name of the container/service. In our case, it was forcing the cookie domain to be "domain=grav-site;".
Basically, under docker, the only way to make it work would be to use "localhost", but that would break a lot of stuff.
This setting allows override of the domain, and it shouldn't break existing applications.