run route.php when grav is not at the root of the server #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coucou... |
|
I'm going to optimize this a bit for readibility, but functionality will remain unchanged. |
|
ok, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if I want to use the
router.phpprovided by Grav I need to startphp -Sin the Grav's root folder.If on the production server, Grav is not installed at the documents root, this will make it slightly more complex to manage the assets.
This patch adds the option to start Grav as:
GRAV_BASEDIR="/grav" php -S localhost:8000 grav/system/router.php(in this case it will also accept "grav" and "grav/" as the basedir values)