Better handle syntax errors in docker labels for a single container

[RoboMagus]

Description

Service discovery fully errors out and will not provide any services if a single container has a syntax error in one of it's labels.

Steps to reproduce

Found this out when trying to add adguard-home with the following labels in docker-compose:

- "homepage.group=Network"
- "homepage.name=Adguard Home"
- "homepage.icon=adguard-home.svg"
- "homepage.href=https://adguard.${DOMAIN}"
- "homepage.description=Home DNS"
- "homepage.widget.type=adguard"
- "homepage.widget.url=http://adguard-home:3002"
- "homepage.widget.username="
- "homepage.widget.password="
- "homepage.widget.fields=queries, blocked, filtered, latency"

When (re-)loading the homepage, all docker services added through labels are no longer present.

Upon removal of the last 3 lines all works well again.

homepage version

v0.6.21

Installation method

Docker

Configuration

No response

Container Logs

[2023-06-28T11:36:07.184Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:36:07.195Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:36:17.429Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:36:17.432Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:36:19.306Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:36:19.307Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:36:25.168Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:36:25.182Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:36:40.178Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:36:40.180Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:37:18.658Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:37:18.660Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:37:23.929Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:37:23.948Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:38:02.253Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:38:02.260Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:42:06.465Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:42:06.469Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:42:08.976Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:42:08.978Z] error: SyntaxError: Unexpected token q in JSON at position 0
[2023-06-28T11:42:11.867Z] error: Failed to discover services, please check docker.yaml for errors o
[2023-06-28T11:42:11.868Z] error: SyntaxError: Unexpected token q in JSON at position 0

Browser Logs

No response

Troubleshooting

It's a service widet, but that's not the part that seems to be failing...

Other

No response

Before submitting, I have made sure to

• Check the documentation
• Follow the troubleshooting guide (please include output above if applicable).
• Search existing issues and discussions.

[RoboMagus]

I believe this might be caused by the following code block being executed inside a try / catch, instead of a try / catch for each of the containers.

https://github.com/benphelps/homepage/blob/b04ed36adb0cac7456a99e182fbed1daae62d639/src/utils/config/service-helpers.js#L77

[shamoon]

I dont think this is a bug, youre asking that homepage handle this better, which is reasonable but theres no claim that it will handle invalid service labels. Its not so different than having an invalid yaml for homepage...

Anyway I can look at doing this later

[RoboMagus]

In my opinion, an unhandled exception or error otherwise related to a smaller component causing a bigger failure should be classified as a bug, regardless of claims.

But thanks for taking a look.

[shamoon]

Closed by #1640

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.