Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Service ping, redesign docker status #505

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Nov 7, 2022

See #388 , I accidentally deleted the head branch closing that one =)

As discussed, this PR implements the ping which uses a HEAD request, also shows estimated latency if status is 200. Changes look of docker status too. As noted users would need to be careful about which URL to ping, if the public domain is behind a reverse-proxy this will potentially falsely always return status 200, instead local URL / ip could be specified to test http status.

Closes #248, closes #78

Screen Shot 2022-10-14 at 2 24 54 PM

services.yaml

    - Paperless-ngx:
        href: https://paperless.domain.com
        description: My awesome Paperless-ngx instance
        icon: paperless.png
        ping: https://google.com
        server: docker
        container: paperless

@abonforti
Copy link
Contributor

Hi, what's the status for this? Can it be merged?

@JazzFisch
Copy link
Collaborator

Hi, what's the status for this? Can it be merged?

I'm reviewing it. I think #502 should go in first though.

@JazzFisch JazzFisch merged commit 354f819 into main Nov 20, 2022
@abonforti
Copy link
Contributor

Hi, is it working? Tried different approaches with using LAN ip, dns, 1.1.1.1, but still getting API error with internal server error.
Logs with LOG_LEVEL=debug only say:

[2022-12-09T16:35:04.239Z] error: undefined

@shamoon shamoon deleted the ping-and-redesign-status branch February 3, 2023 18:25
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Ping for bookmarks [Feature Request] Site up or down indicator
3 participants