Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Repository (base) #25

Merged
merged 4 commits into from
May 4, 2015
Merged

Reorganize Repository (base) #25

merged 4 commits into from
May 4, 2015

Conversation

pradyunsg
Copy link
Contributor

First follow-up PR from #23, adds changes for base branch.

@pradyunsg
Copy link
Contributor Author

The reason that this PR cannot be merged automatically is because I removed all files from master, then checked-out a new base branch off it... I'm fixing that.

@getify
Copy link
Owner

getify commented Mar 31, 2015

I think it would be better for you to ditch your "base" branch and then fork from the official one, if you've got any updates to make to it.

@pradyunsg
Copy link
Contributor Author

That's what I'm doing... 😀

I don't think anyone keeps their titles this way...
@pradyunsg
Copy link
Contributor Author

That's all the changes I think are relavant... Are they all OK?

@pradyunsg
Copy link
Contributor Author

Is this Pull Request OK now?

@getify
Copy link
Owner

getify commented Apr 3, 2015

Sorry, I'm busy out on the road teaching... will come back to this in a couple of days.

@pradyunsg
Copy link
Contributor Author

Sure! That's fine!

getify added a commit that referenced this pull request May 4, 2015
Reorganize Repository (base)
@getify getify merged commit 1b3cad5 into getify:base May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants