Initial joystick client and config implementation. #1

alina-fitsner · 2023-09-22T10:15:25Z

Initial joystick client and config implementation.
Simple in memory LRU cache.
SingleConfig and MultipleConfig getContents implementation.
Exception handling.

Simple in memory LRU cache. SingleConfig and MultipleConfig getContents implementation. Exception handling.

… Examples can be tested via Swagger UI http://localhost:8080/swagger-ui.html after application start.

…adocs.

…t steps to de lombok all sdk code to improve compatibility with higher Java versions.

…oystickContentOptions.

…ctMapper for all sdk classes.

… from json to Object to JoystickContent class.

…ions 21 and above.

…d from Joystick. Remove trailing quotes from serialized response. Remove unused exception constructors. Fix toString for JoystickFullContent and JoystickContent.

…hods, as requested by customer.

…Joystick mapper only methods intended to be used by sdk users. Move all technical methods created for sdk internal code to JoystickUtil.

…hing.

…lugins. Add staging repository URL to examples pom.xml

…ns/setup-java@v1.

ValeriyMaslenikov · 2023-12-08T09:57:51Z

setCacheTTL in the specification was called setCacheExpirationSeconds, could you please rename it
Sounds like the property serialized on the Config level is a little useless for us in this case. Because we have separate methods for returning serialized responses and if we set it on Config level - we will have very strange behavior (like it will return TextNode from getContent. Let's remove it, as we did in .NET library.
Looks like we're missing CL-03

src/main/java/com/getjoystick/sdk/client/endpoints/AbstractApiEndpoint.java

src/main/java/com/getjoystick/sdk/util/ApiCacheKeyUtil.java

…th specification.

…feine cache.

…R, as it is already covered by line response.getCode() >= HttpStatus.SC_SERVER_ERROR.

…o feature/initial_client_impl

Initial joystick client and config implementation.

2ce1d6f

Simple in memory LRU cache. SingleConfig and MultipleConfig getContents implementation. Exception handling.

alina-fitsner requested a review from ValeriyMaslenikov September 22, 2023 10:16

Alina Fitsner added 27 commits September 27, 2023 21:02

Update project structure to single module.

66c222f

Add parametrization to getContent methods.

7f331e2

Endpoint for publishing content updates.

a94cc89

Add Joystick usage examples for getting single and multiple contents.…

d735f63

… Examples can be tested via Swagger UI http://localhost:8080/swagger-ui.html after application start.

Include javadoc generation as part of maven build. Update missing Jav…

df3d87d

…adocs.

De lombok @builder (remove Lombok @builder annotations). This is firs…

13eed41

…t steps to de lombok all sdk code to improve compatibility with higher Java versions.

Move optional getContent/getContents parameters to separate class - J…

0c2fd88

…oystickContentOptions.

Add utility class JoystickMapper to share one static instance of Obje…

ac84ee9

…ctMapper for all sdk classes.

Remove parameterized types from Client interface. Move transformation…

c5a9288

… from json to Object to JoystickContent class.

Remove lombok dependency to avoid compatibility issues with Java vers…

37e275b

…ions 21 and above.

Add more tests for ClientImpl. Use json files to mock results returne…

8475e65

…d from Joystick. Remove trailing quotes from serialized response. Remove unused exception constructors. Fix toString for JoystickFullContent and JoystickContent.

Return JsonNode instead of JoystickContent in JoystickContent.get met…

9b424c5

…hods, as requested by customer.

Replace JoystickContent with JsonNode in Client and ClientImpl.

595e6f5

Switch groupId from com.getjoystick.sdk to com.getjoystick

72c476e

Divide JoystickMapper into JoystickUtil and JoystickMapper. Leave in …

d7e6729

…Joystick mapper only methods intended to be used by sdk users. Move all technical methods created for sdk internal code to JoystickUtil.

Add README file.

d6f44d4

Add CHANGELOG file.

e4bda40

Update pom file with additional information required for maven publis…

4615338

…hing.

Add script for release and maven publishing.

7680b0a

Fix SNAPHOT version. Correct script for release and maven publishing.

f2a989f

Test SHAPSHOT staging deploy.

64ed1ff

Test SHAPSHOT staging deploy. - Change GPG settings.

014eb6b

Test SHAPSHOT staging deploy. - Change GPG settings one more time.

2e02e50

Test SHAPSHOT staging deploy. - Change GPG plugin to org.simplify4u.p…

fac2133

…lugins. Add staging repository URL to examples pom.xml

Test SHAPSHOT staging deploy. - Change release settings.

cdb9e13

Test SHAPSHOT staging deploy. - Change actions/setup-java@v2 to actio…

a8e2dcf

…ns/setup-java@v1.

Test SHAPSHOT staging deploy.Fix scripts.

d5b8a58

ValeriyMaslenikov requested changes Dec 8, 2023

View reviewed changes

Alina Fitsner and others added 9 commits December 11, 2023 11:49

Make release scripts to be triggered only for released code.

5fc377d

Rename setCacheTTL to setCacheExpirationSeconds in order to comply wi…

d05db25

…th specification.

Remove serialized attribute from ClientConfig level.

fad2cf8

Add example how to integrate custom cache implementation based on Caf…

8d34bf8

…feine cache.

Remove redundant check response.getCode() < HttpStatus.SC_SERVER_ERRO…

c2c3aae

…R, as it is already covered by line response.getCode() >= HttpStatus.SC_SERVER_ERROR.

Fix hash calculation logic.

8d72ea7

Fix hash calculation logic. Fix test.

4d3db65

Enable PMD check during maven verify phase.

6692dc4

README updates

7a4604a

joystickteam approved these changes Dec 15, 2023

View reviewed changes

Alina Fitsner added 5 commits December 15, 2023 12:57

Set default cacheExpirationSeconds to 600.

f6404b4

Merge remote-tracking branch 'origin/feature/initial_client_impl' int…

572801c

…o feature/initial_client_impl

Change default cacheExpirationSeconds to 300.

cab9468

+ Add matrix of dependencies for CI (run on multiple platforms)

5fff024

No fail fast on matrix

85575e0

ValeriyMaslenikov force-pushed the feature/initial_client_impl branch from 6090edf to 85575e0 Compare December 15, 2023 10:41

ValeriyMaslenikov and others added 6 commits December 15, 2023 11:44

Try to run tests on zulu

e15916f

Try to enable bytebuddy

c85d7aa

+ Add commit email validation

e97d2b3

Update readme with cache configuration options.

705f01d

Update readme with cache configuration options.

08878b8

Change release type to published.

48fc1d9

ValeriyMaslenikov approved these changes Dec 15, 2023

View reviewed changes

ValeriyMaslenikov merged commit 0c1df52 into main Dec 15, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial joystick client and config implementation. #1

Initial joystick client and config implementation. #1

alina-fitsner commented Sep 22, 2023

ValeriyMaslenikov commented Dec 8, 2023

Initial joystick client and config implementation. #1

Initial joystick client and config implementation. #1

Conversation

alina-fitsner commented Sep 22, 2023

ValeriyMaslenikov commented Dec 8, 2023