MOBILE-675: Native UI for In-app Card payments #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgar-zigis
requested changes
Mar 18, 2022
There was a problem hiding this comment.
- UITextField design should be similar to Android. At the moment dark mode background colour of the text fields is still white. Corner radius differs as well, no visible border.
- When text field is focused, keyboard lifts continue button on top of the text fields. Instead scrolling area should increase and button should be lifted max to the position Android does.
- If continue bank payment modal is displayed and YES/no is clicked, keyboard does not automatically hide
Sources/Kevin/InAppPayments/CardPayment/KevinCardPaymentValidator.swift
Outdated
Show resolved
Hide resolved
Sources/Kevin/InAppPayments/CardPayment/Views/KevinBankTransferPromptView.swift
Outdated
Show resolved
Hide resolved
edgar-zigis
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.