Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"KB", not "kB" in F::niceSize #2607

Closed
rasteiner opened this issue May 6, 2020 · 2 comments · Fixed by #2608
Closed

"KB", not "kB" in F::niceSize #2607

rasteiner opened this issue May 6, 2020 · 2 comments · Fixed by #2608
Assignees
Labels
type: bug 🐛 Is a bug; fixes a bug
Milestone

Comments

@rasteiner
Copy link
Contributor

rasteiner commented May 6, 2020

Hello :)

Describe the bug
"kilobytes", in the context of memory, should be abbreviated as 'KB', currently it's 'kB'. (Or alternatively Kirby should use 1000 as a base for the math).

Additional context
AFAIK: conventionally 1kB = 1000 bytes and 1KB = 1024 bytes.
The nicesize function is using 1024 as a base.
The "standard" for the "power of two units" would actually be "KiB", "MiB", "GiB", etc. While I personally don't know anyone that actually uses those, the lowercase "k" seems to explicitly mean 1000.

See also https://en.wikipedia.org/wiki/Kilobyte and also https://en.wikipedia.org/wiki/Kibibyte

PS: I don't mean to sound pedantic.

@lukasbestle
Copy link
Member

You are right! At first I thought "hm, I have never seen KB being used anywhere", but I've just never noticed it. Will be fixed. :)

@lukasbestle lukasbestle self-assigned this May 6, 2020
@lukasbestle lukasbestle added this to the 3.4.0 milestone May 6, 2020
lukasbestle added a commit that referenced this issue May 6, 2020
lukasbestle added a commit that referenced this issue May 6, 2020
@lukasbestle lukasbestle linked a pull request May 6, 2020 that will close this issue
4 tasks
bastianallgeier pushed a commit that referenced this issue May 8, 2020
@bastianallgeier
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants