Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare JSON docs to avoid unsaved changes loop #3899

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

bastianallgeier
Copy link
Member

Describe the PR

By comparing the ProseMirror JSON docs, subtle differences in the HTML output are no longer relevant. This could really be the needed fix for the problem.

Fixes

#3798

@bastianallgeier bastianallgeier added this to the 3.6.0-rc.4 milestone Nov 2, 2021
@bastianallgeier bastianallgeier requested a review from a team November 2, 2021 20:57
@afbora afbora linked an issue Nov 2, 2021 that may be closed by this pull request
@afbora afbora added type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions labels Nov 2, 2021
Copy link
Member

@afbora afbora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is amazing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Is a bug; fixes a bug type: regression 🚨 Is a regression between versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck in an unsaved changes loop
2 participants