Add CLI specific config file

[lukaskleinschmidt]

This PR …

Adds the option to define a CLI specific config file config.cli.php. You can already do something like this by using the ready callback and define your CLI specific options in there. Probably only for edge cases but when you need CLI specific options I think this would fit in quite nicely with the current system of environment (host name or ip address) specific options.

// config.php
return [
    'ready' => function (App $kirby) {
        $options = [
            //
        ];

        if ($kirby->environment()->cli()) {
            $options = array_merge($options, [
                'option.one' => 1,
                'option.two' => 2,
            ]);
        }

        return $options;
    }
];

// config.cli.php
return [
    'option.one' => 1,
    'option.two' => 2,
];

Related: https://discord.com/channels/525634039965679616/525641819854471168/1149657559746224188

Breaking changes

Hopefully none.

Ready?

• Unit tests for fixed bug/feature
• In-code documentation (wherever needed)
• Tests and checks all pass

For review team

• Add changes to release notes draft in Notion
• Add to website docs release checklist (if needed)

[distantnative]

Overall, I like the idea.

Any thoughts if this could cause problems elsewhere, @bastianallgeier @lukasbestle?

[lukasbestle]

In theory it could clash with a host named cli, but that's very unlikely in practice and will only take effect if the host cli was explicitly allowlisted in the main config.php.

So I'd say it should be safe.

[distantnative]

@lukaskleinschmidt Would you mind adding unit tests for this? Once with cli active and extra config loading, once with inactive and ignoring the cli config file? You can force the cli state for testing as done here https://github.com/getkirby/kirby/blob/develop/tests/Http/EnvironmentTest.php#L223-L231

[lukaskleinschmidt]

I will try to get to it. But currently too busy

[bastianallgeier]

I really like it as well!

[lukaskleinschmidt]

I had the same issue locally regarding the failed test https://github.com/getkirby/kirby/actions/runs/6429036429/job/17457332224?pr=5581 but wanted to make sure this is not related to my setup.

Changing the test case for the failing test would fix the issue. But not sure if this is the proper way to do this here.

public function testOptionsFromInvalidHost()
{
	$env = new Environment([
		'cli' => false, // <- this one here
		'allowed' => [
			'http://example.de'
		]
	], [
		'SERVER_NAME' => 'example.com'
	]);

	$this->assertSame([], $env->options($this->config));
}

[lukasbestle]

@lukaskleinschmidt I think that would be the correct solution. The test assumes an HTTP request with the SERVER_NAME environment variable, so we need to fake CLI mode off for the test to make sense.