Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix line break when label in block preview fields is too long #6452

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix line break when label in block preview fields is too long #6452

merged 1 commit into from
Jun 4, 2024

Conversation

tobimori
Copy link
Contributor

@tobimori tobimori commented May 20, 2024 •
edited by bastianallgeier
Loading

This PR …

fixes this
CleanShot 2024-05-20 at 12 22 07@2x

Fixes

Above

Breaking changes

None

Docs

None

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@tobimori tobimori changed the title fix line break when label is too long fix line break when label in block preview fields is too long May 20, 2024
@distantnative distantnative requested a review from a team May 20, 2024 10:37
@distantnative distantnative modified the milestones: 4.2.1, 4.3.0 May 20, 2024
@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label May 20, 2024
@bastianallgeier bastianallgeier merged commit 75b4c82 into getkirby:develop-minor Jun 4, 2024
2 checks passed
@bastianallgeier
Copy link
Member

Thanks for the fix! I changed it a tiny bit and added some test cases to our lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobimori @bastianallgeier @distantnative