scala 3.4.2 #385
Merged
scala 3.4.2 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
May 17, 2024
| @@ -17,18 +18,23 @@ object Loops: | |||
| private val _continueUnit = Continue[Unit](()) | |||
|
|
|||
| inline def continue[T]: Result[Unit, T] = _continueUnit | |||
| inline def done[T]: Result[T, Unit] = () | |||
There was a problem hiding this comment.
The compiler doesn't line the inline overloaded methods anymore. This should be ok since the method will be inlined by the JIT compiler.
fwbrasil
commented
May 17, 2024
| @@ -45,7 +45,7 @@ class varsTest extends KyoTest: | |||
| assert(outerValue == 1) | |||
| } | |||
| } | |||
| } | |||
| }.pure | |||
There was a problem hiding this comment.
Interesting that this was compiling before, it shouldn't.
There was a problem hiding this comment.
Did this only happen after adding the Int type?
There was a problem hiding this comment.
Actually I could have removed the Int annotations. It was my initial attempt but then I saw pure was missing.
hearnadam
approved these changes
May 17, 2024
| @@ -45,7 +45,7 @@ class varsTest extends KyoTest: | |||
| assert(outerValue == 1) | |||
| } | |||
| } | |||
| } | |||
| }.pure | |||
There was a problem hiding this comment.
Did this only happen after adding the Int type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.