Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoupdate code review updates #136

Merged
merged 11 commits into from
Mar 23, 2015
Merged

Autoupdate code review updates #136

merged 11 commits into from
Mar 23, 2015

Conversation

oxtoacart
Copy link
Contributor

Main changes:

  • Switched to using semantic versioning with semver package
  • Simplified autoupdate API (which also took care of a race condition or two)
  • Updated example to show restart after update
  • Using golog
  • Slightly more informative error messages in a few places

@oxtoacart
Copy link
Contributor Author

@xiam - Here are some suggested changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.91% when pulling 74b2680 on feature/autoupdate-ox into 37a6717 on feature/autoupdate.

@xiam
Copy link
Contributor

xiam commented Mar 23, 2015

@oxtoacart Thank you Ox, looking into it.

@xiam xiam merged commit 74b2680 into feature/autoupdate Mar 23, 2015
@xiam
Copy link
Contributor

xiam commented Mar 23, 2015

Cools suggestions Ox!

@xiam xiam deleted the feature/autoupdate-ox branch March 23, 2015 17:15
@oxtoacart
Copy link
Contributor Author

Glad you liked them, thanks for reviewing!

@getlantern getlantern deleted a comment from fffw Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xiam xiam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxtoacart @coveralls @xiam