Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added topics support to waddell, increased test coverage #2

Merged
merged 36 commits into from
Dec 17, 2014

Conversation

oxtoacart
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.52%) when pulling 2e7c90f on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.52%) when pulling 37b3d60 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.52%) when pulling 41dc1c2 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.52%) when pulling d743998 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.52%) when pulling 50bf9e2 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) when pulling 0c3f2c3 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.42%) when pulling 0c3f2c3 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.33%) when pulling 732c7fa on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling d4cc22e on channelwad into 56a0389 on master.

@aranhoide
Copy link
Contributor

I'm finally done reviewing this; overall it looks very solid to me, pending review of the change to initialize Clients on construction. I'll review the related PRs in other repos tomorrow, then QA it and merge it all together.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling 2c4ea5a on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling 7370724 on channelwad into 56a0389 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.27%) when pulling 6dd823d on channelwad into 56a0389 on master.

aranhoide added a commit that referenced this pull request Dec 17, 2014
Added topics support to waddell, increased test coverage
@aranhoide aranhoide merged commit d80bb3d into master Dec 17, 2014
@aranhoide aranhoide deleted the channelwad branch December 17, 2014 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants