Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topic ID is optional #3

Closed
wants to merge 2 commits into from
Closed

Conversation

ed2k
Copy link

@ed2k ed2k commented Jan 3, 2015

go-natty demo program receive message from public waddell server without topic id (i.e only 16 bytes uuid assigned by server)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling af419b1 on ed2k:optional_topicid into d80bb3d on getlantern:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling 5d217f5 on ed2k:optional_topicid into d80bb3d on getlantern:master.

@oxtoacart
Copy link
Contributor

@ed2k Actually the demo program does use a topic - https://github.com/getlantern/go-natty/blob/master/demo/proxy.go#L87

@oxtoacart oxtoacart closed this Jan 5, 2015
@ed2k
Copy link
Author

ed2k commented Jan 5, 2015

then, why did waddell server returns a message without topic?

@oxtoacart
Copy link
Contributor

@ed2k Can you construct a unit test to reproduce what you're seeing please?

@ed2k
Copy link
Author

ed2k commented Jan 5, 2015

@oxtoacart the go-natty demo program won't work without this.
./demo -mode server will complain the received message is 16bytes, and expecting 18bytes.

@oxtoacart
Copy link
Contributor

I think the waddell server may have a bad version deployed. I'll check it out in a little bit.

@oxtoacart
Copy link
Contributor

@ed2k Okay, I think it should work now. Can you please try again?

@ed2k
Copy link
Author

ed2k commented Jan 6, 2015

yes, works for me now.

@oxtoacart
Copy link
Contributor

@ed2k Thanks for testing, and thanks for letting us know about the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants