Add Server-Side encryption option for SQS, fixes #138 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Is it possible to pass a key defined in my CloudFormation resources somehow? |
|
@webmozart Hey! Judging by the docs & code in the PR (I'm not using that feature) I don't think this is possible. The construct seems to be creating the key itself, and seems to be expecting a key value (not an existing key ID or ARN). |
|
@mnapoli Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended SQS options with
encryptionandencryptionKeyto enable Server-Side encryption.If
encryptionis set tokmsManaged, key will be managed by SQS.If it is set to
kms, thenencryptionKeywill be required.Closes #138