Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockPublicAccess required config #384

Merged

Conversation

kevincerro
Copy link
Contributor

@kevincerro kevincerro commented Feb 20, 2024

Fixes #320

Description

Since april 2023, AWS S3 enforces two new default bucket security settings by automatically enabling S3 Block Public Access and disabling S3 access control lists (ACLs) for all new S3 buckets

This hotfix adds missing required BlockPublicAccess configuration.

How to Reproduce

Deploy this stack and error is thrown.

service: demo

provider:
    name: aws
    region: eu-west-3
    stage: prod

plugins:
    - serverless-lift

constructs:
    demo:
        type: static-website
        path: dist

Before

Captura de pantalla 2024-02-20 a las 23 27 10

After

image

@richard-stafflink
Copy link

Bonjour @mnapoli,
Pourriez-vous Review/Merge s'il vous plaît?
Nous en avons besoin.

@mnapoli
Copy link
Member

mnapoli commented Jun 22, 2024

Thank you @kevincerro, awesome job!

@mnapoli mnapoli merged commit 0d56286 into getlift:master Jun 22, 2024
@kevincerro kevincerro deleted the hotfix/static-website-public-access branch August 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static-site construct will not deploy
3 participants