-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom sort title and sorting titles #259
Merged
hkalexling
merged 21 commits into
getmango:dev
from
Leeingnyo:feature/custom-sort-title-and-sorting-titles
Jan 15, 2022
Merged
Implement custom sort title and sorting titles #259
hkalexling
merged 21 commits into
getmango:dev
from
Leeingnyo:feature/custom-sort-title-and-sorting-titles
Jan 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a placeholder for the default display name Remove some console.log() callings
Refactor remove cache
It's really complicated to delete columns in sqlite3! haha I didn't know that. Thank you for fixing! |
Haha no problem. I will test and review the rest of the PR soon. Happy new year! 🎆 |
hkalexling
approved these changes
Jan 15, 2022
Sorry for the long delay. I included the Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182
New
DB
sort_title
onids
andtitles
tables (migration file no.12)API
/api/admin/sort_title/:title_id
name
is an optional query parameter and if empty, makesort_title
null
Server
sort_title
insteadtitle
for sorting titles and entries in auto and title optionsUI
Sort Title
field below theDisplay Name
field in edit modalfile title
(same withtitle
mentioned in [Feature Request] Custom sort order #182 (comment)) at theDisplay Name
field and theSort Title
fieldFixes
UI