-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjusting README and Dockerfile for x86_64 and arm64 usage #22
Conversation
…e for usage with x86_64 and arm64
d74465d
to
f1b9e78
Compare
Solves #19 |
Thanks for your updates! Can we add a more meaningful error message when we try to spin up the image on macos or windows host system? Right now I am receiving the following message:
On a minor note, please use the |
This should just run on macOS and there should be no error at all. Will have a look in a few minutes. The error indicates that the build arg is not populated on macOS. |
The problem here is the redefinition of the The use of build args in docker is a little tricky: |
But was it actually working with podman, @Urfoex? |
I would add that the users shouldn't be concerned about the stochastic nature of the token at all: Just name it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments. Otherwise LGTM. Great work!
Yeah, I guess podman sees "These arguments are defined in the global scope" differently then docker.
Adjusted.
I put |
…ker, simplify by removing multiarch parts. Using heredoc for multiline RUN
lgtm. have a good merge! |
…t in README for better bind-mount use with alternatives
… have ARCH specific arguments
…m with composed stage name resultion (containers/buildah#4820)
No description provided.