Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix response_parameter being ignored in put_integration_response #2954

Merged
merged 3 commits into from
May 4, 2020
Merged

Fix response_parameter being ignored in put_integration_response #2954

merged 3 commits into from
May 4, 2020

Conversation

usmangani1
Copy link
Contributor

@usmangani1
Copy link
Contributor Author

#2953

@spulec Can you please help me get this merged.

@coveralls
Copy link

coveralls commented May 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.0008%) to 94.215% when pulling d6875c2 on usmangani1:LSTACK_AWSPROXY into 3167f4a on spulec:master.

@usmangani1
Copy link
Contributor Author

Coverage Status

Coverage increased (+0.0006%) to 94.217% when pulling 1cda64e on usmangani1:LSTACK_AWSPROXY into 3167f4a on spulec:master.

@bblommers Can you please help me here to get this merged ?

@usmangani1
Copy link
Contributor Author

Coverage Status
Coverage increased (+0.0006%) to 94.217% when pulling 1cda64e on usmangani1:LSTACK_AWSPROXY into 3167f4a on spulec:master.

@bblommers Can you please help me here to get this merged ?

@bblommers can u help me here please ?

bblommers
bblommers approved these changes May 4, 2020
View reviewed changes
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bblommers bblommers merged commit 323877c into getmoto:master May 4, 2020
@bblommers bblommers mentioned this pull request May 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bblommers bblommers bblommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@usmangani1 @coveralls @bblommers @usmankb