-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Mock region #4699
Feature: Mock region #4699
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4699 +/- ##
==========================================
+ Coverage 95.28% 95.29% +0.01%
==========================================
Files 556 556
Lines 61017 60594 -423
==========================================
- Hits 58140 57745 -395
+ Misses 2877 2849 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the bandwidth to review all the changes across all 98 files, but I understand the problem this PR aims to solve and I think the implementation makes sense.
The added tests do seem to cover the new functionality, so if all the other tests still pass this LGTM.
Understandable! Thanks @bpandola |
This is now part of moto >= 2.3.0.dev3 |
Feature to allow a user to specify a non-existing region. Having a non-existent region can be useful as an additional layer of protection, to ensure the user does not modify real AWS architecture.
This feature is disabled by default, but can be enabled with an environment variable. (
MOTO_ALLOW_NONEXISTENT_REGION
)In order to make this work, all backends are now generated on-request, rather then on start-up.
This results in:
Closes #4252