-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LakeFormation: extend permissions catalog functionality #7156
LakeFormation: extend permissions catalog functionality #7156
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7156 +/- ##
========================================
Coverage 95.88% 95.89%
========================================
Files 834 834
Lines 82221 82318 +97
========================================
+ Hits 78838 78938 +100
+ Misses 3383 3380 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JohannesKoenigTMH, thanks for the PR! This looks like the right approach - O just have a few minor comments
I am not sure where this failing test in python 3.7 for lambda invoke comes from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM. Thank you for adding this to Moto @JohannesKoenigTMH!
This is now part of moto >= 4.2.14.dev2 |
Implementation for issue #7150