Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LakeFormation: extend permissions catalog functionality #7156

Conversation

JohannesKoenigTMH
Copy link
Contributor

@JohannesKoenigTMH JohannesKoenigTMH commented Dec 22, 2023

Implementation for issue #7150

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2b077a2) 95.88% compared to head (ef1e427) 95.89%.
Report is 18 commits behind head on master.

Files Patch % Lines
moto/lakeformation/models.py 88.57% 8 Missing ⚠️
moto/ec2/models/launch_templates.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7156    +/-   ##
========================================
  Coverage   95.88%   95.89%            
========================================
  Files         834      834            
  Lines       82221    82318    +97     
========================================
+ Hits        78838    78938   +100     
+ Misses       3383     3380     -3     
Flag Coverage Δ
servertests 35.46% <26.82%> (-0.34%) ⬇️
unittests 95.83% <87.80%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JohannesKoenigTMH, thanks for the PR! This looks like the right approach - O just have a few minor comments

moto/lakeformation/models.py Outdated Show resolved Hide resolved
moto/lakeformation/models.py Outdated Show resolved Hide resolved
tests/test_lakeformation/test_lakeformation.py Outdated Show resolved Hide resolved
@JohannesKoenigTMH
Copy link
Contributor Author

JohannesKoenigTMH commented Jan 8, 2024

I am not sure where this failing test in python 3.7 for lambda invoke comes from.
Edit: Seems to be resolved 👍

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM. Thank you for adding this to Moto @JohannesKoenigTMH!

@bblommers bblommers added this to the 4.2.14 milestone Jan 10, 2024
@bblommers bblommers changed the title extend lake formation permissions catalog functionality LakeFormation: extend permissions catalog functionality Jan 10, 2024
@bblommers bblommers merged commit 9d30b1a into getmoto:master Jan 10, 2024
35 checks passed
Copy link
Contributor

This is now part of moto >= 4.2.14.dev2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lake formation does not correctly handle permissions on already known principal-resource-pairs
2 participants