Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit service name for sso-admin #7717

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

giograno
Copy link
Contributor

This small PR fixes the service name passed to the BackendDict for the SSO Admin service.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.33%. Comparing base (f4eaa87) to head (e3cfdcc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7717   +/-   ##
=======================================
  Coverage   94.33%   94.33%           
=======================================
  Files        1087     1087           
  Lines       92858    92858           
=======================================
  Hits        87598    87598           
  Misses       5260     5260           
Flag Coverage Δ
servertests 29.48% <100.00%> (ø)
unittests 94.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giograno giograno marked this pull request as ready for review May 22, 2024 22:02
@bblommers bblommers added this to the 5.0.8 milestone May 24, 2024
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you @giograno!

@bblommers bblommers merged commit 79a1003 into getmoto:master May 24, 2024
40 checks passed
@giograno giograno deleted the sso-backend-name branch May 24, 2024 14:36
Copy link
Contributor

This is now part of moto >= 5.0.8.dev21

jfmainville pushed a commit to jfmainville/moto that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants