Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: update_item() now validates empty string sets #8031

Merged

Conversation

bblommers
Copy link
Collaborator

Fixes #8022

@bblommers bblommers added this to the 5.0.14 milestone Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.41%. Comparing base (9d7a102) to head (d96a8e2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8031   +/-   ##
=======================================
  Coverage   94.41%   94.41%           
=======================================
  Files        1134     1134           
  Lines       96764    96765    +1     
=======================================
+ Hits        91356    91358    +2     
+ Misses       5408     5407    -1     
Flag Coverage Δ
servertests 29.01% <8.33%> (-0.01%) ⬇️
unittests 94.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit ed926f0 into getmoto:master Aug 23, 2024
50 checks passed
@bblommers bblommers deleted the dynamodb-validate-empty-string-set branch August 23, 2024 09:46
Copy link
Contributor

This is now part of moto >= 5.0.14.dev22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB should return a ValidationError if you try to put an item with an empty string set
1 participant