fix: use 'within-url-limit' for APQ requests
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0fff540 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KrisQ
approved these changes
Apr 27, 2023
NWRichmond
changed the title
'within-url-limit' for APQ requests
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Addresses ENG-9515
As described in urql-graphql/urql#3185,
@urql/exchange-persistedcurrently sets urql'spreferGetMethodsetting to'force'. This was causing problems with an especially large query inreference-stores/next/pages/collections/[handle].js.This issue is demonstrated with
@nacelle/storefront-sdk@/2.0.0-beta.10in https://codesandbox.io/s/nacelle-storefront-sdk-2-0-0-demo-failure-to-fetch-with-prefergetmethod-force-2u9kjm.What is this pull request doing?
This PR patches
@urql/exchange-persistedusingpatch-package. The patch changes thepreferGetMethodsetting from'force'to'within-url-limit'when@urql/exchange-persisted'spreferGetForPersistedQueriessetting is set totrue.How to Test
ENG-9515/patch-urql-exchange-persistedbranchnpm run bootstrapfrom the monorepo rootpackages/storefront-sdknpm run build- the package should build without issuesnpm run coverage- all tests should pass with 100% coveragereference-stores/nextnpm run build- the project should build without errorsI tested this change by publishing
@nacelle/storefront-sdk@2.0.0-hotfix.0with thev2-hotfixtag, and using it in a forked version of the bug demo Code Sandbox from above. As show in https://codesandbox.io/s/nacelle-storefront-sdk-2-0-0-demo-prefergetmethod-within-url-limits-hb0zkm?file=/src/index.ts, the request succeeds. Interestingly, it succeeds with a GET, without converting the request to a POST. I'm not yet sure why this works, but it's a good result nonetheless.Checklist
nacelle-js' Code of Conduct.