Correctly analyze the response of manual registrations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endpoint redirects, and the client follows the redirect. We should be looking for a 2xx response, not a 3xx response. In some vendor upgrade somewhere, we lost the propagation of the session cookie. Set the redirect policy so we send it if we're redirecting to the same host.
rossabaker
commented
Jun 14, 2017
| SetDebug(globalEnableDebug) | ||
| SetDebug(globalEnableDebug). | ||
| RedirectPolicy(func(req gorequest.Request, via []gorequest.Request) error { | ||
| // Copy the Cookie on redirect if the hosts match |
There was a problem hiding this comment.
My understanding is that net/http client (line 633) should handle this, but it's not.
We're being sloppy about case insensitivity of hosts and the HTTP spec, but I think this is enough to make the feature work without compromising the Nelson API or accidentally spewing credentials in case Nelson starts redirecting somewhere else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint redirects, and the client follows the redirect. We should be
looking for a 2xx response, not a 3xx response.
In some vendor upgrade somewhere, we lost the propagation of the session cookie.
Set the redirect policy so we send it if we're redirecting to the same host.