Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2531 — pass post and lang to compilers #2532

Merged
merged 8 commits into from Oct 15, 2016
Merged

Conversation

@Kwpolska
Copy link
Member

Kwpolska commented Oct 14, 2016

This is #2531. There isn’t anything else we could post to this function, so hopefully we won’t have to do real_compile next time.

cc @felixfontein, reviews welcome.

Copy link
Contributor

felixfontein left a comment

LGTM. No idea about the failing tests, though...

@Kwpolska
Copy link
Member Author

Kwpolska commented Oct 14, 2016

This is so stupid. Apparently, is_one_file can make things break if set incorrectly (perhaps due to metadata splitting). I’ll fix it and merge.

@felixfontein
Copy link
Contributor

felixfontein commented Oct 14, 2016

Why not fix the test instead of (again) having the compilers compile signature disagree with the signature in PageCompiler?

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska
Copy link
Member Author

Kwpolska commented Oct 14, 2016

Or we can make the PageCompiler signature match.

And the problem is not really in the test. is_two_file set to False means some extra manipulation which should not be the default.

@Kwpolska Kwpolska merged commit f5d42cf into master Oct 15, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Kwpolska Kwpolska deleted the new-compile-function branch Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.