Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading XML media attachment results in "invalid error" #243

Closed
lognaturel opened this issue Dec 12, 2019 · 2 comments · Fixed by #257
Closed

Uploading XML media attachment results in "invalid error" #243

lognaturel opened this issue Dec 12, 2019 · 2 comments · Fixed by #257

Comments

@lognaturel
Copy link
Member

lognaturel commented Dec 12, 2019 •
edited

Using external-xml.zip and frontend:

  1. Upload the form
  2. Attempt to upload the XML media attachment

A red banner with "Something went wrong: the server returned an invalid error." The upload appears to succeed but the file is empty.

versions:
75f11f18b6d697a73b025b46a9d0e7f6e2e5f0c0
U0000000000000000000000000000000000000000 client
+63ecaece46a52fd0e8cf4a0f64b2d189660e149b server (v0.6.0-beta.0-54-g63ecaec)
@lognaturel lognaturel mentioned this issue Dec 12, 2019
Closed
@issa-tseng
Copy link
Member

0.6? why not 0.7?

@lognaturel
Copy link
Member Author

I was using antinodes for trying something with Collect. Is it easy for you to try to repro on a more recent environment? It's not urgent, this is not a very widely used feature.

Note that I also uploaded other forms with other media types at that same time so that's why I suspect it's related to the media type but I suppose it could be something else.

issa-tseng added a commit that referenced this issue Mar 31, 2020
@issa-tseng
refactor+bug #243: accept xml form attachments; stream-process all xml.
b43c5ce 
* previously, we had a middleware layer automatically buffer all xml
  request bodies to a string so we could handle it easier.
* but this means that the form attachment resource, which expects
  streaming inputs from the request body, would find nothing.
* additionally, we are much better now at handling streams that we used
  to be, and in general we should be stream-processing things.
* so in this commit, we remove that middleware layer, and we switch to
  stream-processing xml for new forms and submissions.
* this also meant shoring up some of the streams and promises.
* resolves #243.
@issa-tseng issa-tseng linked a pull request Apr 7, 2020 that will close this issue
[wip] block 8 cleanup items #257
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wip] block 8 cleanup items getodk/central-backend
2 participants
@issa-tseng @lognaturel