[wip] block 8 cleanup items #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* due to a constraint.
* incidentally resolves the infinite looping issue.
* since we need the instanceId to generate the decryption IV. * (usually we just autogenerate an id if we don't see one). * resolves #253.
* previously, we had a middleware layer automatically buffer all xml request bodies to a string so we could handle it easier. * but this means that the form attachment resource, which expects streaming inputs from the request body, would find nothing. * additionally, we are much better now at handling streams that we used to be, and in general we should be stream-processing things. * so in this commit, we remove that middleware layer, and we switch to stream-processing xml for new forms and submissions. * this also meant shoring up some of the streams and promises. * resolves #243.
* it's not the most crucial test.
* when a new draft is created.
* everything in this commit is a really awful hack and i'm extremely sorry about it. * resolves #124.
matthew-white
approved these changes
Apr 6, 2020
* this is necessary because of a quirk in API communication; the role summary API for forms operates off xmlFormIds rather than acteeIds, so deleted forms' assignments could collide with recreated forms. * the longer term fix would be to start exposing acteeIds over the API.
This was
linked to
issues
Apr 7, 2020
issa-tseng
commented
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidentally resolves #256