Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See entity update in submission feed #513

Closed
ktuite opened this issue Sep 27, 2023 · 6 comments · Fixed by getodk/central-frontend#873
Closed

See entity update in submission feed #513

ktuite opened this issue Sep 27, 2023 · 6 comments · Fixed by getodk/central-frontend#873
Assignees
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI

Comments

@ktuite
Copy link
Member

ktuite commented Sep 27, 2023

I think this image and set of notes in the release criteria is about the entity feed:
From release criteria (comment)
unnamed

The submission feed will also have a note about how the submission updated an entity, but it probably wont show the diff.

@ktuite ktuite added frontend Requires a change to the UI needs testing Needs manual testing entities Multiple Encounter workflows labels Sep 27, 2023
@matthew-white
Copy link
Member

matthew-white commented Sep 27, 2023

I think #507 covers entries in the entity feed, but that's a great point that we'll also need to update the submission feed. What do you think about making this issue just about the submission feed?

  • As with entity.create events, we'll need to handle the case where the entity is deleted.
  • Will we need to do anything extra to surface and display errors from failed entity updates?

@matthew-white matthew-white changed the title Verify that entity update shows correctly in submission and entity feeds Verify that entity update shows correctly in submission feed Sep 28, 2023
@matthew-white matthew-white changed the title Verify that entity update shows correctly in submission feed See entity update in submission feed Sep 28, 2023
@matthew-white matthew-white added the enhancement New feature or behavior label Sep 28, 2023
@ktuite ktuite self-assigned this Oct 17, 2023
@ktuite ktuite linked a pull request Oct 17, 2023 that will close this issue
2 tasks
@matthew-white matthew-white added the needs design review Needs verification from designer label Nov 17, 2023
@issa-tseng
Copy link
Member

looks nice, only thought is maybe it should like the feed item related to the submission if it can? okay if no

@matthew-white
Copy link
Member

Just to be sure, you mean showing the diff, as well as information about the conflict (if there is one)? I think that'd be doable.

@matthew-white
Copy link
Member

Would it look confusing if there end up being two different types of diffs on that page? At the moment, submission diffs and entity diffs look a bit different.

@srujner
Copy link

srujner commented Dec 7, 2023

Tested With Success!

@dbemke
Copy link

dbemke commented Dec 7, 2023

Tested with success!

@dbemke dbemke added behavior verified Behavior has been manually verified and removed needs testing Needs manual testing labels Dec 7, 2023
@matthew-white matthew-white removed the needs design review Needs verification from designer label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behavior verified Behavior has been manually verified enhancement New feature or behavior entities Multiple Encounter workflows frontend Requires a change to the UI
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

5 participants