Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app crashes if a user bulk finalizes drafts that do not have their form definitions #5833

Closed
grzesiek2010 opened this issue Nov 14, 2023 · 1 comment · Fixed by #5835
Closed
Assignees
Milestone

Comments

@grzesiek2010
Copy link
Member

grzesiek2010 commented Nov 14, 2023

ODK Collect version

v2023.3.0

Problem description

The app crashes if a user bulk finalizes drafts that do not have their form definitions.

Steps to reproduce the problem

  1. Save any form as draft
  2. Go to Settings -> Project management -> Reset, select the third option (Blank forms...), and click the reset button.
  3. Open the list of drafts and try to bulk finalize the saved forms

Expected behavior

There should be no crash and the draft that does not have its form definition should be ignored.

Other information

It's visible in our crash reports: https://console.firebase.google.com/u/1/project/api-project-322300403941/crashlytics/app/android:org.odk.collect.android/issues/5e5e34af343a0e2172d530fdce799f08?time=last-thirty-days&types=crash&versions=v2023.3.0%20(4724)&sessionEventKey=654C458C03C9000124FF4BF5D9B31D60_1877732972590742889

@grzesiek2010 grzesiek2010 added this to the v2023.3.x milestone Nov 14, 2023
@grzesiek2010 grzesiek2010 self-assigned this Nov 14, 2023
@github-project-automation github-project-automation bot moved this to not ready in ODK Collect Nov 14, 2023
@grzesiek2010 grzesiek2010 moved this from not ready to in progress in ODK Collect Nov 14, 2023
@grzesiek2010 grzesiek2010 changed the title The app crashes if a user bul finalizes drafts that do not have their form definitions The app crashes if a user bulk finalizes drafts that do not have their form definitions Nov 14, 2023
@grzesiek2010
Copy link
Member Author

There is another scenario that can cause a similar crash during bulk finalization:

  1. Save any form as draft.
  2. Delete the form file manually from the project directory (the one from the forms subdirectory)
  3. Open the list of drafts and try to bulk finalize the saved forms

@seadowg seadowg linked a pull request Nov 15, 2023 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from in progress to done in ODK Collect Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

1 participant