Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Database access ANRs #5838

Open
seadowg opened this issue Nov 15, 2023 · 3 comments
Open

Fix Database access ANRs #5838

seadowg opened this issue Nov 15, 2023 · 3 comments
Milestone

Comments

@seadowg
Copy link
Member

seadowg commented Nov 15, 2023

An example was reported here.

Our forms and instances databases should not be accessed the UI thread. We can use StrictMode.noteSlowCall in our DatabaseConnection (on accessing a writable or readable DB) to detect these in debug builds and instrumented tests.

@seadowg seadowg added this to the v2023.4 milestone Nov 15, 2023
@seadowg seadowg self-assigned this Nov 28, 2023
@seadowg seadowg modified the milestones: v2024.1, v2024.2 Jan 26, 2024
@seadowg seadowg removed their assignment Jan 31, 2024
@seadowg
Copy link
Member Author

seadowg commented Feb 1, 2024

After the work done in #5867, the main focus to get this done is to be able to call StrictMode.noteSlowCall("Accessing readable DB") in DatabaseConnection instead of in the database backed repository implementations and have all tests passing.

@seadowg
Copy link
Member Author

seadowg commented May 10, 2024

The goal here now will be to remove the strict parameter from DatabaseConnected (always call noteSlowCall on DB accesses).

@seadowg seadowg self-assigned this Jun 3, 2024
@seadowg
Copy link
Member Author

seadowg commented Jun 3, 2024

It looks like a significant rewrite (replacing InstanceChooserList most noteably) is required to make any more progress here so let's move it to the next release.

@seadowg seadowg modified the milestones: v2024.2, v2024.3 Jun 3, 2024
@seadowg seadowg removed their assignment Jun 3, 2024
@seadowg seadowg modified the milestones: v2024.3, v2024.4 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ready
Development

No branches or pull requests

1 participant