Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No error" pill is gray #6046

Closed
dbemke opened this issue Mar 27, 2024 · 7 comments
Closed

"No error" pill is gray #6046

dbemke opened this issue Mar 27, 2024 · 7 comments

Comments

@dbemke
Copy link

dbemke commented Mar 27, 2024

ODK Collect version

the master version 38a4b0e

Android version

10, 14

Device used

Redmi 9T, Pixel 7a

Problem description

The "No error” pill in Drafts changed color to gray (used to be blue).
The issue doesn’t occur in the store version 2024.1.3
gray

Steps to reproduce the problem

  1. Set light mode in Collect.
  2. Save a draft without errors.
  3. Go to Drafts

Expected behavior

The "No error” pill should be blue.

@grzesiek2010
Copy link
Member

grzesiek2010 commented Mar 28, 2024

@alyblenkin what do you think? Is gray ok or we should use blue?

@alyblenkin
Copy link
Collaborator

alyblenkin commented Mar 28, 2024

It would be great if we could use blue and red here to emphasize the states. @seadowg, is it still possible to use blue with the new tonal surface changes? I think it's okay to use gray for the end screen and messages, but here, it's important for it to be highlighted.

@seadowg
Copy link
Member

seadowg commented Mar 29, 2024

@seadowg, is it still possible to use blue with the new tonal surface changes? I think it's okay to use gray for the end screen and messages, but here, it's important for it to be highlighted.

We could just use our primary color?

@dbemke
Copy link
Author

dbemke commented Mar 29, 2024

After merging #6000 the gray "no errors" pill occurs also in the form map.

@grzesiek2010
Copy link
Member

We could just use our primary color?

I'm not sure... @alyblenkin?
Screenshot_1711737419

@alyblenkin
Copy link
Collaborator

We could just use our primary color?

Ideally, I would use a lighter colour because we reserve the primary colour for our buttons.

Another thought I just had was to make the pill outlines blue, which surprisingly works pretty well.
The mockups below don't have the form icon, so they will look different. The pills are also fully rounded (something I want to get to eventually!).

Screenshot 2024-04-02 at 9 16 18 AM

@seadowg
Copy link
Member

seadowg commented Apr 8, 2024

@alyblenkin I just remembered that there isn't a spec for Pill, so we can do whatever we want here really (as long as we feel it's probably what "Google would want"). Let's schedule a pairing session to improve this.

@seadowg seadowg closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

4 participants