Disable reconfiguring in GD projects #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Aug 24, 2023
|
Tested with Success! Verified on device with Android 10 Verified cases:
The PR was tested on selfsigned build of the apk, it will be tested again in the final build (with upgrades and GD projects) before release. |
|
Tested with Success! |
seadowg
pushed a commit
that referenced
this pull request
Sep 5, 2023
Disable reconfiguring in GD projects
This was referenced Oct 3, 2023
This was referenced Oct 18, 2023
Merged
This was referenced Oct 31, 2023
5 tasks
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5704
What has been done to verify that this works as intended?
I've tested the fix manually and added automated tests.
Why is this the best possible solution? Were any other approaches considered?
We decided that disabling reconfiguring for GD projects would be a good solution for GD projects that still exist to avoid loosing data.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Reconfiguring projects should be disabled (not visible) for GD projects. It's a safe change so verifying that the option is visible for non-GD projects nd hidden for GD projects would be enough.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.