-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show dialog when the user sees the drafts screen for the first time #5785
Conversation
What is the expected result when there are 2 projects in Collect? The dialog is shown in Drafts only in the first project which is opened (when in the second project Drafts is opened for the first time- no dialog)? |
Arg, good catch.
We need to be mindful of that in criteria. I think once overall is fine. |
This should be fixed. |
@seadowg and I briefly discussed this and were hoping to defer the test infrastructure for this until we had more of these education dialogs! But I think your interim approach of dismissing the dialog as needed is ok and we can come back to it. I guess having the dialog show in debug builds and running tests would have revealed the Sent issue! |
The dialog disappears (in Drafts) after the screen rotation. I think it would be useful to keep the dialog after the rotation cause users may accidentally change the position of the phone without having a chance to read the dialog. |
I think @seadowg used that typo of dialog deliberately maybe even after discussing it with @lognaturel so let's wait for what @lognaturel thinks. To me, it's not that important. |
@lognaturel We have already tested everything and there are no more bugs. If you think that the things in Dominika's comment are ok, you can close and merge this PR. |
e40316a
to
0f764d5
Compare
Great, it seems ok to me, thanks. |
Show dialog when the user sees the drafts screen for the first time
Show dialog when the user sees the drafts screen for the first time
The dialog currently only shows in non debug builds to avoid needing to build test infrastructure to deal with it.