Make message ID on submission page copyable (version 2) #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output is identical, but this removes the duplication of the Message ID itself in the source. Signed-off-by: Ross Burton <ross.burton@arm.com>
Don't limit the clipboardjs hooking to button.btn-copy, as we may want to use it on icons which are not buttons. Signed-off-by: Ross Burton <ross.burton@arm.com>
Add an icon alongside the message ID to copy the message ID to the clipboard, to ease integration with eg b4. Signed-off-by: Ross Burton <ross.burton@arm.com>
stephenfin
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directly conflicts with #572.
Add a little "copy" button to the message ID field so that the user can copy the message ID to the clipboard. This makes working with b4 from a terminal easier because it's just one-click to get the IDs.
Also depends on and incorporates #576, for the updated glyphicon font with a 'copy' icon.