show docker build output (#785) #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivotron
requested changes
Jul 14, 2020
src/popper/runner_host.py
Outdated
| @@ -212,9 +212,17 @@ def _create_container(self, cid, step): | |||
| if build: | |||
| log.info(f"[{step.id}] docker build {img}:{tag} {build_ctx_path}") | |||
| if not self._config.dry_run: | |||
| self._d.images.build( | |||
|
|
|||
| _, build_logs = self._d.images.build( | |||
There was a problem hiding this comment.
this blocks, so the output only shows until images.build() returns. If the output of the build is too big, this might cause memory issues. In order to avoid this, this code can use the low-level API as exemplified here. Very similar to what what's already here, but with a couple of tweaks.
|
thanks! I made some tweaks based on what you have in this PR and pushed them to https://github.com/getpopper/popper/tree/pr/882 . Does all that make sense to you? If it does, can you please rebase that branch from this PR? |
|
nice! I did the rebase and it works smoothly. |
|
great, thanks! can you please push the changes to this PR, so I can merge from here? otherwise your authorship is going to get lost. |
|
sure 😁 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows docker build output by default and when the
--quiet flagis given topopper runit hides it.