Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorized output to log.info and log.step_info for bracket prefixes #946

Closed
wants to merge 3 commits into from

Conversation

zacswolf
Copy link

@zacswolf zacswolf commented Dec 5, 2020

Fixes #541. @ivotron your feedback would be appreciated

Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @zacswolf, this looks great! Would it be possible to add coloring for the msg_prefix string as well? That'd be really cool! To test you can run with popper run --dry-run

@zacswolf zacswolf force-pushed the master branch 3 times, most recently from 0666202 to 06df4c1 Compare December 12, 2020 22:16
Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, only the error being thrown by black in CI

@zacswolf
Copy link
Author

@ivotron How do I fix this formatting issue? I ran the black linter locally on python3.8 and was able to successfully format the file that is causing the CI build issues (runner_slurm.py).

@ivotron ivotron closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: colorize output
3 participants